Fixed write() freezing entire Sketch unless MIDI port is opened by PC…#5
Closed
odbol wants to merge 1 commit intoarduino-libraries:masterfrom
Closed
Fixed write() freezing entire Sketch unless MIDI port is opened by PC…#5odbol wants to merge 1 commit intoarduino-libraries:masterfrom
odbol wants to merge 1 commit intoarduino-libraries:masterfrom
Conversation
Contributor
|
Thank you very much for the PR. I've adapted your code to fix compilation on non-Due boards and merged as b360489 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix Issue #4. Not sure if it's the correct way to do it, since I don't see that method used on the CDC connection, however it works great on my DrumPants! Most likely works on Due as well.